Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set priority class for kube-scheduler and cluster-autoscaler #6838

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/area control-plane
/kind bug

What this PR does / why we need it:
See #5634 (comment)

Which issue(s) this PR fixes:
Part of #5634

Release note:

`kube-scheduler` and `cluster-autoscaler` Pods now run with the appropriate priority set according to the following [document](https://github.com/gardener/gardener/blob/v1.57.1/docs/development/priority-classes.md). Previously these Pods were running without a priority class set and were preempted in favour of less important Pods.

@gardener-prow gardener-prow bot added area/control-plane Control plane related kind/bug Bug labels Oct 16, 2022
@gardener-prow gardener-prow bot requested review from acumino and shafeeqes October 16, 2022 16:28
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2022
@rfranzke
Copy link
Member

/lgtm
/approve
/retest

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 17, 2022

@ialidzhikov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-e2e-kind-ha-multi-zone 1964926 link false /test pull-gardener-e2e-kind-ha-multi-zone
pull-gardener-check-vulnerabilities 1964926 link false /test pull-gardener-check-vulnerabilities

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gardener-prow gardener-prow bot merged commit bbe19d1 into gardener:master Oct 17, 2022
@ialidzhikov ialidzhikov deleted the fix/cp-priorityclasses branch October 17, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane Control plane related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants