Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guided Tour: Subinst with templating #1139

Merged
merged 8 commits into from
Jun 11, 2024
Merged

Guided Tour: Subinst with templating #1139

merged 8 commits into from
Jun 11, 2024

Conversation

achimweigel
Copy link
Contributor

What this PR does / why we need it:

Extend Guided Tour by subinstallations with templating.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Extend Guided Tour by subinstallations with templating.

@achimweigel achimweigel requested a review from a team as a code owner June 10, 2024 08:27
@gardener-robot gardener-robot added the needs/review Needs review label Jun 10, 2024
@achimweigel achimweigel requested review from robertgraeff and removed request for enrico-kaack-comp June 10, 2024 08:27
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jun 10, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 10, 2024
@achimweigel achimweigel marked this pull request as draft June 10, 2024 12:37
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 10, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 10, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 10, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 11, 2024
@achimweigel achimweigel marked this pull request as ready for review June 11, 2024 02:01
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 11, 2024
@achimweigel achimweigel merged commit 80a6a1d into gardener:master Jun 11, 2024
5 checks passed
@achimweigel achimweigel deleted the subinst-with-templating branch June 11, 2024 07:09
@In-Ko In-Ko added the area/ipcei IPCEI (Important Project of Common European Interest) label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertgraeff robertgraeff robertgraeff approved these changes

@In-Ko In-Ko Awaiting requested review from In-Ko In-Ko is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@achimweigel @robertgraeff @gardener-robot-ci-1 @In-Ko @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot