Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make repository context in context resource optional #1156

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Make repository context in context resource optional #1156

merged 1 commit into from
Jun 28, 2024

Conversation

robertgraeff
Copy link
Member

@robertgraeff robertgraeff commented Jun 26, 2024 •
edited
Loading

What this PR does / why we need it:

To process an Installation, a repository context is needed, which specifies in which OCM repos we search for component versions. It can be specified:

  • in the Installation,
  • in the referenced Context resource, or
  • in the OCM config, that is referenced in the Context resource.

Even if repository contexts were specified in the OCM config, it was still required to specify an additional repository context in the Context resource. With this PR this is no longer required.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

- It is no longer required to specify a repository context in a Context resource.

@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Jun 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 26, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 26, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 27, 2024
@robertgraeff robertgraeff marked this pull request as ready for review June 28, 2024 06:21
@robertgraeff robertgraeff requested a review from a team as a code owner June 28, 2024 06:21
@robertgraeff robertgraeff merged commit 3380893 into gardener:master Jun 28, 2024
5 checks passed
@robertgraeff robertgraeff deleted the optional-context branch June 28, 2024 06:59
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 28, 2024
@In-Ko In-Ko added the area/ipcei IPCEI (Important Project of Common European Interest) label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimweigel achimweigel achimweigel approved these changes

@fabianburth fabianburth Awaiting requested review from fabianburth fabianburth is a code owner automatically assigned from gardener/landscaper-maintainers

@jensh007 jensh007 Awaiting requested review from jensh007 jensh007 is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robertgraeff @achimweigel @In-Ko @gardener-robot-ci-3 @gardener-robot