Fix helm log function #1193
Merged
Fix helm log function #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertgraeff
requested review from
achimweigel
and removed request for
Diaphteiros
gardener-robot
added
the
size/xs
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
|
@robertgraeff are you sure that this is required? If you look at my change before, the call was exactly the same? I just got it. This is the reason why we often see these strange log messages from helm. Got it. :-) |
achimweigel
approved these changes
Jul 31, 2024
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes how the helm log function fills a list of values into a format string. The first placeholder of the format string was filled with the complete value list, instead of only the first value. All other placeholder did not get a value. As a result, the log messages looked for example like this:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: