Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create OCM context only if necessary #1223

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

robertgraeff
Copy link
Member

@robertgraeff robertgraeff commented Sep 2, 2024

What this PR does / why we need it:

Deployers have always created an OCM Context at the beginning of the Reconcile method. As a consequence, OCM Contexts were often created unnecessarily, for example if the deployer was not responsible for a DeployItem, or if the DeployItem was already in a finished phase. With this PR the creation of OCM Contexts is postponed, and therefore skipped if not needed.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

- Reduction of memory consumption by creating OCM Contexts only if needed.

Copy link

gardener-prow bot commented Sep 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Sep 2, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 2, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 2, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 2, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 2, 2024
@robertgraeff robertgraeff marked this pull request as ready for review September 2, 2024 14:09
@robertgraeff robertgraeff requested a review from a team as a code owner September 2, 2024 14:09
@gardener-robot gardener-robot added size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Sep 5, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 5, 2024
@robertgraeff robertgraeff merged commit 8f30966 into gardener:master Sep 5, 2024
5 checks passed
@robertgraeff robertgraeff deleted the deployer-ocm-context branch September 5, 2024 08:33
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 5, 2024
@In-Ko In-Ko added the area/ipcei IPCEI (Important Project of Common European Interest) label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants