Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix local linter run #1239

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix local linter run #1239

merged 1 commit into from
Sep 17, 2024

Conversation

achimweigel
Copy link
Contributor

What this PR does / why we need it:

Fix local linter runs

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix local linter runs

@achimweigel achimweigel requested a review from a team as a code owner September 17, 2024 06:25
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Sep 17, 2024
@achimweigel achimweigel requested a review from guewa September 17, 2024 06:25
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 17, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 17, 2024
@guewa
Copy link
Contributor

guewa commented Sep 17, 2024

works locally, waiting for in tests to finish

@achimweigel achimweigel merged commit c2bddf5 into gardener:master Sep 17, 2024
5 checks passed
@achimweigel achimweigel deleted the fix-local-linter-run branch September 17, 2024 07:50
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guewa guewa guewa approved these changes

@reshnm reshnm Awaiting requested review from reshnm reshnm is a code owner automatically assigned from gardener/landscaper-maintainers

@Diaphteiros Diaphteiros Awaiting requested review from Diaphteiros Diaphteiros is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@achimweigel @guewa @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot