Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated secretRef field from Target structure #1243

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Remove deprecated secretRef field from Target structure #1243

merged 2 commits into from
Sep 19, 2024

Conversation

robertgraeff
Copy link
Member

What this PR does / why we need it:

The content of a Target can be maintained in a referenced Secret. The correct field in a Target for such a reference is .spec.secretRef. This does not change.

Long ago, there was another field for the reference, namely .spec.config.kubeconfig.secretRef. This field has been deprecated for a long time and will be removed with this PR.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

- Cleanup deprecated fields from Target structure

@gardener-prow Gardener Prow
Copy link

gardener-prow bot commented Sep 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Sep 18, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 18, 2024
@robertgraeff robertgraeff changed the title Remove deprecated secretRef from targets Remove deprecated secretRef field from Target structure Sep 18, 2024
@robertgraeff robertgraeff force-pushed the remove-deprecated-target-structure branch from c275c88 to f5728a9 Compare September 19, 2024 06:25
@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Sep 19, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2024
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Sep 19, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 19, 2024
@robertgraeff robertgraeff marked this pull request as ready for review September 19, 2024 12:01
@robertgraeff robertgraeff requested a review from a team as a code owner September 19, 2024 12:01
@robertgraeff robertgraeff force-pushed the remove-deprecated-target-structure branch from 6b74dfd to f7ff48b Compare September 19, 2024 12:11
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2024
@robertgraeff robertgraeff merged commit aadbb72 into gardener:master Sep 19, 2024
5 checks passed
@robertgraeff robertgraeff deleted the remove-deprecated-target-structure branch September 19, 2024 14:07
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 19, 2024
@In-Ko In-Ko added the area/ipcei IPCEI (Important Project of Common European Interest) label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimweigel achimweigel achimweigel approved these changes

@reshnm reshnm Awaiting requested review from reshnm reshnm is a code owner automatically assigned from gardener/landscaper-maintainers

@jensh007 jensh007 Awaiting requested review from jensh007 jensh007 is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@robertgraeff @achimweigel @gardener-robot-ci-1 @In-Ko @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot