Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework component version overwrites #430

Merged
merged 26 commits into from
Oct 26, 2022
Merged

rework component version overwrites #430

merged 26 commits into from
Oct 26, 2022

Conversation

Diaphteiros
Copy link
Contributor

@Diaphteiros Diaphteiros commented Mar 2, 2022 •
edited
Loading

How to categorize this PR?

/area usability
/kind enhancement
/priority 3

What this PR does / why we need it:
The 'old' component overwrites were specified cluster-wide, opposed to all other configurations where Landscaper assumes a namespace to be an independent tenant.

To solve this in a backward compatible manner, the old implementation has not been changed. It still works as before, but is deprecated now. A new namespace-scoped resource called ComponentVersionOverwrites has been introduced, which looks similar to the old format, although there are some differences in behaviour.

Special notes for your reviewer:
Not finished yet, open TODOs:

  • write unit tests for the overwrite logic
  • documentation
  • we need further (integration?) tests to ensure that also the references of CDs are overwritten

Release note:

The `ComponentOverwrites` custom resource has been removed and is replaced by the new `ComponentVersionOverwrites` custom resource, which is namespace-scoped. If you upgrade from an existing Landscaper installation, you have to migrate all `ComponentOverwrites` resources to the new format and delete the `ComponentOverwrites` CRD afterwards. See the [documentation](docs/usage/ComponentOverwrites.md) for further information.

@gardener-robot gardener-robot added area/usability Usability related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 2, 2022
@Diaphteiros
Copy link
Contributor Author

cc @mandelsoft @reshnm

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 2, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 2, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 2, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 2, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 2, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 2, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 3, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 4, 2022
@reshnm reshnm mentioned this pull request Mar 11, 2022
Merged
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 4, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 5, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 5, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 15, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 15, 2022
Diaphteiros and others added 18 commits October 25, 2022 15:27
@Diaphteiros
add integration test for componentversionoverwrites
a92991c
@Diaphteiros
add debug log for unready CRDs
6a3c183
@Diaphteiros
remove unused testdata files
dd7e5b3
@Diaphteiros
add componentversionoverwrites test to verify that references of alre…
9aa2806 
…ady replaced components are also overwritten (run-int-tests)
@Diaphteiros @reshnm
Update apis/core/types_component_version_overwrite.go
ef29950 
Co-authored-by: René Schünemann <rene.schuenemann@sap.com>
@Diaphteiros
fix comment and make generate
620e1d4
@Diaphteiros
fix gap between documentation and actual coding
66a9afa
@Diaphteiros
add some logging
c9595d4
@Diaphteiros
remove componentoverwrite type
f3257a5
@Diaphteiros
remove old componentoverwrites completely (run-int-tests)
cadeaa3
@Diaphteiros
fix component version overwrites for subinstallation creation
96e3f91
@Diaphteiros
add explicit reference to componentversionoverwrites to context resou…
f2a873b 
…rce (run-int-tests)
@Diaphteiros
fix missing stuff (run-int-tests)
df18be5
@Diaphteiros
fix component version overwrites for subinstallations (again) (run-in…
9a13341 
…t-tests)
@Diaphteiros
fix condition formatting
e176dc8
@Diaphteiros
adapt documentation
04d3cb8
@Diaphteiros
fix wrong cvo name
0fe3373
@Diaphteiros
fix docs
c309620
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 25, 2022
reshnm
reshnm approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@reshnm reshnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels Oct 26, 2022
@Diaphteiros Diaphteiros merged commit 7d82dae into gardener:master Oct 26, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 26, 2022
@Diaphteiros Diaphteiros deleted the overwrite branch October 26, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reshnm reshnm reshnm approved these changes

@In-Ko In-Ko Awaiting requested review from In-Ko In-Ko is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) priority/3 Priority (lower number equals higher priority) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Diaphteiros @gardener-robot @reshnm @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3