Helm deployer Int Test #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@enrico-kaack-comp You need rebase this pull request with latest master branch. Please check. |
gardener-robot
added
needs/rebase
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
robertgraeff
requested changes
Sep 30, 2022
| "github.com/gardener/landscaper/pkg/deployer/helm" | ||
| lsutils "github.com/gardener/landscaper/pkg/utils/landscaper" | ||
|
|
||
| . "github.com/onsi/ginkgo" |
There was a problem hiding this comment.
Achim has updated ginkgo to ginkgo/v2:
Suggested change
| . "github.com/onsi/ginkgo" | |
| . "github.com/onsi/ginkgo/v2" |
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
robertgraeff
requested changes
Sep 30, 2022
| Expect(err).ShouldNot(HaveOccurred()) | ||
| readinesCheck := getReadinessCheck(state.Namespace, jsonRawMessage) | ||
|
|
||
| di := deployDeployItemAndWaitForSuccess(ctx, f, state.State, deployName, chartDir, valuesFile, nil, &readinesCheck, realHelmDeployer) |
There was a problem hiding this comment.
This should fail, shouldn't it?
There was a problem hiding this comment.
good catch thank you. I missed that during refactoring.
|
@achimweigel You have pull request review open invite, please check |
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
robertgraeff
approved these changes
Oct 4, 2022
|
@achimweigel You have pull request review open invite, please check |
gardener-robot
added
reviewed/lgtm
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area helm-deployer
/kind test
What this PR does / why we need it:
Add tests for helm deployer (real helm deployer and helm templating deployer each):
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: