-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new manifest deployer update strategies #624
Merged
reshnm
merged 5 commits into
gardener:master
from
reshnm:resource-applier-patch-strategy
Oct 25, 2022
Merged
add new manifest deployer update strategies #624
reshnm
merged 5 commits into
gardener:master
from
reshnm:resource-applier-patch-strategy
Oct 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diaphteiros
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test |
Testrun: e2e-28frm +--------------------+--------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +--------------------+--------------------+-----------+----------+ | create-cluster | create-cluster | Succeeded | 3m13s | | create-registry | create-registry | Succeeded | 2m46s | | install-landscaper | install-landscaper | Succeeded | 53s | | integration-test | test | Failed | 6m15s | | delete-cluster | delete-cluster | Omitted | 0s | | delete-registry | delete-registry | Omitted | 0s | +--------------------+--------------------+-----------+----------+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/manifest-deployer
Manifest Deployer related
kind/enhancement
Enhancement, improvement, extension
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/second-opinion
Needs second review by someone else
priority/3
Priority (lower number equals higher priority)
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area manifest-deployer
/kind enhancement
/priority 3
What this PR does / why we need it:
The previously available manifest deployer update strategies
update
andpatch
were not sufficient for resources that are being modified by a kubernetes controller after being created (like Gardener Shoots). The available strategies would always overwrite these modfications.This PR introduces two new update strategies to accomodate the use case scenarios:
merge
: The manifest deployer will merge the results of the rendered manifests into the resources on the cluster. Fields that already exist in the resources on the cluster, will not be overwritten.mergeOverwrite
: The manifest deployer will merge the results of the rendered manifests into the resources on the cluster. Fields that already exist in the resources on the cluster, will be overwritten when the rendered field is not empty.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: