Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

landscaper service blueprint updates #638

Merged
merged 2 commits into from
Nov 21, 2022
Merged

landscaper service blueprint updates #638

merged 2 commits into from
Nov 21, 2022

Conversation

reshnm
Copy link
Member

@reshnm reshnm commented Nov 15, 2022 •
edited
Loading

How to categorize this PR?

/area operations
/kind enhancement
/priority 3

What this PR does / why we need it:

  • Add an optional ingress resource for the landscaper webhooks server in the landscaper chart.
  • Refactoring of the landscaper service blueprint.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Add an optional ingress resource for the landscaper webhooks server in the landscaper chart.

@reshnm reshnm requested a review from a team as a code owner November 15, 2022 16:14
@gardener-robot gardener-robot added the priority/3 Priority (lower number equals higher priority) label Nov 15, 2022
@reshnm reshnm marked this pull request as draft November 15, 2022 16:14
@gardener-robot
Copy link

@reshnm Labels area/todo, kind/todo do not exist.

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 15, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 15, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 15, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 15, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 16, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 16, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 16, 2022
@reshnm reshnm force-pushed the shoot-cluster-updates branch from f41b4f3 to a1e5c40 Compare November 16, 2022 16:58
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 16, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 17, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 17, 2022
@reshnm
add landscaper webhooks ingress
ff4a686 
update landscaper service blueprint
@reshnm reshnm force-pushed the shoot-cluster-updates branch from e0f50c8 to ff4a686 Compare November 18, 2022 08:46
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 18, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 18, 2022
@reshnm reshnm changed the title [draft ]shoot cluster updates landscaper service blueprint updates Nov 18, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 18, 2022
@gardener-robot
Copy link

@reshnm Labels area/todo, kind/todo do not exist.

@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 18, 2022
@gardener-robot gardener-robot added area/operations Operation related kind/enhancement Enhancement, improvement, extension labels Nov 18, 2022
@reshnm reshnm marked this pull request as ready for review November 18, 2022 08:50
@reshnm reshnm requested a review from achimweigel November 18, 2022 08:51
@gardener-robot
Copy link

@achimweigel, @robertgraeff, @Diaphteiros You have pull request review open invite, please check

achimweigel
achimweigel approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@achimweigel achimweigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 21, 2022
@reshnm reshnm merged commit 4d8b7a2 into gardener:master Nov 21, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimweigel achimweigel achimweigel approved these changes

@Diaphteiros Diaphteiros Awaiting requested review from Diaphteiros Diaphteiros is a code owner automatically assigned from gardener/landscaper-maintainers

@robertgraeff robertgraeff Awaiting requested review from robertgraeff robertgraeff is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/operations Operation related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) priority/3 Priority (lower number equals higher priority) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@reshnm @gardener-robot @achimweigel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3