Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert the virtual-garden removal #639

Merged
merged 1 commit into from
Nov 22, 2022
Merged

revert the virtual-garden removal #639

merged 1 commit into from
Nov 22, 2022

Conversation

reshnm
Copy link
Member

@reshnm reshnm commented Nov 21, 2022

How to categorize this PR?

/area operations
/kind enhancement
/priority 3

What this PR does / why we need it:+

This PR reverts the replacement of the virtual-garden component with shoot clusters in the landscaper-service component.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Revert the replacement of the virtual-garden component with shoot clusters in the landscaper-service component.

@reshnm reshnm requested a review from a team as a code owner November 21, 2022 16:14
@reshnm reshnm requested review from achimweigel and In-Ko November 21, 2022 16:14
@gardener-robot gardener-robot added area/operations Operation related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 21, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 21, 2022
achimweigel
achimweigel approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@achimweigel achimweigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 22, 2022
@reshnm reshnm merged commit 55255df into gardener:master Nov 22, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimweigel achimweigel achimweigel approved these changes

@In-Ko In-Ko Awaiting requested review from In-Ko In-Ko is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/operations Operation related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) priority/3 Priority (lower number equals higher priority) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@reshnm @achimweigel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot