Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly set field createNamespace to true in landscaper-service blueprint #642

Merged
merged 1 commit into from
Nov 23, 2022
Merged

explicitly set field createNamespace to true in landscaper-service blueprint #642

merged 1 commit into from
Nov 23, 2022

Conversation

reshnm
Copy link
Member

@reshnm reshnm commented Nov 23, 2022

How to categorize this PR?

/area operations
/kind enhancement
/priority 3

What this PR does / why we need it:

Explicitly set field createNamespace to true in helm deployments of landscaper-service blueprint.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Explicitly set field `createNamespace` to true in helm deployments of landscaper-service blueprint.

@reshnm reshnm requested a review from a team as a code owner November 23, 2022 10:38
@gardener-robot gardener-robot added area/operations Operation related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 23, 2022
@reshnm reshnm requested a review from achimweigel November 23, 2022 10:38
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 23, 2022
@reshnm reshnm merged commit 96d4948 into gardener:master Nov 23, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 23, 2022
@robertgraeff robertgraeff mentioned this pull request Nov 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimweigel achimweigel achimweigel approved these changes

@Diaphteiros Diaphteiros Awaiting requested review from Diaphteiros Diaphteiros is a code owner automatically assigned from gardener/landscaper-maintainers

@robertgraeff robertgraeff Awaiting requested review from robertgraeff robertgraeff is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/operations Operation related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review priority/3 Priority (lower number equals higher priority) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reshnm @achimweigel @gardener-robot-ci-3 @gardener-robot