Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dns settings to landscaper webhook ingress #670

Merged
merged 1 commit into from
Jan 20, 2023
Merged

add dns settings to landscaper webhook ingress #670

merged 1 commit into from
Jan 20, 2023

Conversation

reshnm
Copy link
Member

@reshnm reshnm commented Jan 19, 2023

How to categorize this PR?

/area operations
/kind enhancement
/priority 3

What this PR does / why we need it:

For operating our own ingress controller, the webhooks server ingress needs to be annotated with garden dns settings.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Add dns settings to landscaper webhook ingress.

@reshnm reshnm requested a review from a team as a code owner January 19, 2023 11:35
@gardener-robot gardener-robot added area/operations Operation related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 19, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 19, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 19, 2023
achimweigel
achimweigel approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@achimweigel achimweigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 19, 2023
@reshnm reshnm added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 19, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 19, 2023
@reshnm reshnm added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 20, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 20, 2023
@reshnm reshnm merged commit 5f84626 into gardener:master Jan 20, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimweigel achimweigel achimweigel approved these changes

@robertgraeff robertgraeff Awaiting requested review from robertgraeff robertgraeff is a code owner automatically assigned from gardener/landscaper-maintainers

@enrico-kaack-comp enrico-kaack-comp Awaiting requested review from enrico-kaack-comp enrico-kaack-comp is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/operations Operation related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) priority/3 Priority (lower number equals higher priority) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@reshnm @achimweigel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot