Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix component descriptor #759

Merged
merged 5 commits into from
Jun 13, 2023
Merged

Fix component descriptor #759

merged 5 commits into from
Jun 13, 2023

Conversation

achimweigel
Copy link
Contributor

How to categorize this PR?

/area delivery
/kind bug
/priority 3

What this PR does / why we need it:

Fix component descriptor.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

- fix component descriptor

@gardener-prow
Copy link

gardener-prow bot commented Jun 12, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-robot gardener-robot added area/delivery Delivery related kind/bug Bug priority/3 Priority (lower number equals higher priority) needs/review Needs review labels Jun 12, 2023
@achimweigel achimweigel requested a review from robertgraeff June 12, 2023 12:48
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Jun 12, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 12, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 12, 2023
@achimweigel achimweigel marked this pull request as ready for review June 13, 2023 04:50
@achimweigel achimweigel requested a review from a team as a code owner June 13, 2023 04:50
@achimweigel achimweigel requested review from In-Ko and reshnm and removed request for In-Ko June 13, 2023 04:50
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 13, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 13, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 13, 2023
@guewa
Copy link
Contributor

guewa commented Jun 13, 2023

the same component_descriptor changes were here #758, which can now be closed.

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 13, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 13, 2023
@achimweigel achimweigel merged commit 7dd1cb5 into gardener:master Jun 13, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 13, 2023
@robertgraeff robertgraeff deleted the fix-cd branch June 13, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertgraeff robertgraeff robertgraeff approved these changes

@guewa guewa guewa approved these changes

@reshnm reshnm Awaiting requested review from reshnm

Assignees
No one assigned
Labels
area/delivery Delivery related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review priority/3 Priority (lower number equals higher priority) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@achimweigel @guewa @robertgraeff @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot