Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readiness checks retry on kubernetes client errors #760

Merged
merged 1 commit into from
Jun 13, 2023
Merged

readiness checks retry on kubernetes client errors #760

merged 1 commit into from
Jun 13, 2023

Conversation

reshnm
Copy link
Member

@reshnm reshnm commented Jun 13, 2023 •
edited
Loading

How to categorize this PR?

/area deployer
/kind enhancement
/priority 3

What this PR does / why we need it:

Preciously the readiness check was aborted when there was any error reported by the kubectl client api.
These errors are now considered recoverable and do not abort the readiness check.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Kubernetes client errors will be considered recoverable and will no longer abort the readiness checks.

@reshnm reshnm requested a review from a team as a code owner June 13, 2023 08:09
@gardener-robot gardener-robot added kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) labels Jun 13, 2023
@gardener-robot
Copy link

@reshnm Label area/deployer does not exist.

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jun 13, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 13, 2023
@gardener-robot
Copy link

@reshnm Label area/deployer does not exist.

@reshnm reshnm merged commit c6e8380 into gardener:master Jun 13, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertgraeff robertgraeff robertgraeff approved these changes

@achimweigel achimweigel Awaiting requested review from achimweigel achimweigel is a code owner automatically assigned from gardener/landscaper-maintainers

@enrico-kaack-comp enrico-kaack-comp Awaiting requested review from enrico-kaack-comp enrico-kaack-comp is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review priority/3 Priority (lower number equals higher priority) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reshnm @gardener-robot @robertgraeff @gardener-robot-ci-2