Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add MergeMaps function to controller-utils library #806

Merged
merged 1 commit into from
Aug 30, 2023
Merged

add MergeMaps function to controller-utils library #806

merged 1 commit into from
Aug 30, 2023

Conversation

Diaphteiros
Copy link
Contributor

How to categorize this PR?

/area dev-productivity
/kind enhancement
/priority 3

What this PR does / why we need it:
Adds a MergeMaps function to the controller-utils library. The function allows to merge multiple maps (with identical key and value types).

Release note:

A `MergeMaps` function has been added to the controller-utils library.

@Diaphteiros Diaphteiros requested a review from a team as a code owner August 29, 2023 14:36
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 29, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 29, 2023
achimweigel
achimweigel approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@achimweigel achimweigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 30, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 30, 2023
@Diaphteiros Diaphteiros merged commit 8733126 into gardener:master Aug 30, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 30, 2023
@Diaphteiros Diaphteiros deleted the utility branch August 30, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimweigel achimweigel achimweigel approved these changes

@fabianburth fabianburth Awaiting requested review from fabianburth fabianburth is a code owner automatically assigned from gardener/landscaper-maintainers

@enrico-kaack-comp enrico-kaack-comp Awaiting requested review from enrico-kaack-comp enrico-kaack-comp is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) priority/3 Priority (lower number equals higher priority) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Diaphteiros @achimweigel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot