Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce error logging #807

Merged
merged 10 commits into from
Sep 1, 2023
Merged

Reduce error logging #807

merged 10 commits into from
Sep 1, 2023

Conversation

achimweigel
Copy link
Contributor

How to categorize this PR?

/area deployers
/kind cleanup
/priority 3

What this PR does / why we need it:

Reduce error logging.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Reduce error logging

@gardener-prow
Copy link

gardener-prow bot commented Aug 30, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-robot gardener-robot added area/deployers Deployer related kind/cleanup Something that is not needed anymore and can be cleaned up priority/3 Priority (lower number equals higher priority) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Aug 30, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 30, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 30, 2023
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Aug 30, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 30, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 31, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 31, 2023
@achimweigel achimweigel marked this pull request as ready for review September 1, 2023 00:22
@achimweigel achimweigel requested a review from a team as a code owner September 1, 2023 00:22
@achimweigel achimweigel requested a review from reshnm September 1, 2023 00:22
@achimweigel
Copy link
Contributor Author

  • Landscaper
    • Error logs reduced with this PR
    • Info logs checked -> no problems
  • LaaS
    • Error logs checked -> no problems
    • Info logs about 2.000.000 entries pre day -> fix from Rene is already on the way

Recheck when LaaS info log fix is on live
Recheck all in November

@achimweigel achimweigel merged commit 514fe14 into gardener:master Sep 1, 2023
@achimweigel achimweigel deleted the improve-logging branch September 1, 2023 08:19
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertgraeff robertgraeff robertgraeff approved these changes

@reshnm reshnm Awaiting requested review from reshnm reshnm is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/deployers Deployer related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review priority/3 Priority (lower number equals higher priority) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@achimweigel @robertgraeff @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot