Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce KeyResource values to be of type string #808

Merged
merged 1 commit into from
Aug 31, 2023
Merged

enforce KeyResource values to be of type string #808

merged 1 commit into from
Aug 31, 2023

Conversation

reshnm
Copy link
Member

@reshnm reshnm commented Aug 31, 2023

How to categorize this PR?

/area logging
/kind bug
/priority 3

What this PR does / why we need it:

Logging parameter types must be consistent. There have been some logs where the KeyResource value was not of type string.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

enforce KeyResource values to be of type string

@reshnm reshnm requested a review from a team as a code owner August 31, 2023 09:32
@reshnm reshnm requested review from In-Ko and fabianburth August 31, 2023 09:32
@gardener-robot gardener-robot added area/logging Logging related kind/bug Bug priority/3 Priority (lower number equals higher priority) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 31, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 31, 2023
achimweigel
achimweigel approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@achimweigel achimweigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 31, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 31, 2023
@reshnm reshnm merged commit 0094c88 into gardener:master Aug 31, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimweigel achimweigel achimweigel approved these changes

@In-Ko In-Ko Awaiting requested review from In-Ko In-Ko is a code owner automatically assigned from gardener/landscaper-maintainers

@fabianburth fabianburth Awaiting requested review from fabianburth fabianburth is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/logging Logging related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) priority/3 Priority (lower number equals higher priority) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@reshnm @achimweigel @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot