Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execution controller deletes deploy items during delete without uninstall #810

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Execution controller deletes deploy items during delete without uninstall #810

merged 1 commit into from
Sep 4, 2023

Conversation

achimweigel
Copy link
Contributor

How to categorize this PR?

/area deployers
/kind enhancement
/priority 3

What this PR does / why we need it:

If an installation with the delete-without-uninstall annotation is deleted, the deploy items are removed by the execution controller and not by the deployer anymore. This prevents problems e.g. if the targets are already removed and therefore no deployer is responsible.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

- Execution controller deletes deploy items during delete without uninstall

@gardener-prow
Copy link

gardener-prow bot commented Sep 1, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-robot gardener-robot added area/deployers Deployer related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 1, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 1, 2023
@achimweigel achimweigel marked this pull request as ready for review September 4, 2023 07:52
@achimweigel achimweigel requested a review from a team as a code owner September 4, 2023 07:52
@achimweigel achimweigel requested review from Diaphteiros, fabianburth and robertgraeff and removed request for fabianburth September 4, 2023 07:52
@achimweigel achimweigel merged commit b61300b into gardener:master Sep 4, 2023
@achimweigel achimweigel deleted the delete-without-uninstall branch September 4, 2023 13:07
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertgraeff robertgraeff robertgraeff approved these changes

@Diaphteiros Diaphteiros Awaiting requested review from Diaphteiros Diaphteiros is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/deployers Deployer related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review priority/3 Priority (lower number equals higher priority) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achimweigel @robertgraeff @gardener-robot-ci-1 @gardener-robot