Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump component-spec dependency #812

Merged
merged 2 commits into from
Sep 5, 2023
Merged

bump component-spec dependency #812

merged 2 commits into from
Sep 5, 2023

Conversation

Diaphteiros
Copy link
Contributor

@Diaphteiros Diaphteiros commented Sep 4, 2023 •
edited
Loading

How to categorize this PR?

/area quality
/kind technical-debt
/priority 3

What this PR does / why we need it:
Bump component-spec dependency. This also removes the restriction that top-level domains in component-descriptor names cannot be longer than 4 characters.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The top-level domains in names of component-descriptors can now be longer than four characters.

@gardener-prow
Copy link

gardener-prow bot commented Sep 4, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-robot gardener-robot added the priority/3 Priority (lower number equals higher priority) label Sep 4, 2023
@gardener-robot
Copy link

@Diaphteiros Labels area/todo, kind/todo do not exist.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 4, 2023
@Diaphteiros Diaphteiros force-pushed the remove-domain-restriction branch from fc858ca to 7fbf37c Compare September 4, 2023 13:43
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 4, 2023
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly labels Sep 4, 2023
@Diaphteiros Diaphteiros force-pushed the remove-domain-restriction branch from f45e5c2 to d53b562 Compare September 4, 2023 14:35
@Diaphteiros Diaphteiros force-pushed the remove-domain-restriction branch from d53b562 to 322f50d Compare September 4, 2023 14:35
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 4, 2023
@Diaphteiros Diaphteiros marked this pull request as ready for review September 4, 2023 14:41
@Diaphteiros Diaphteiros requested a review from a team as a code owner September 4, 2023 14:41
@ccwienk ccwienk self-requested a review September 4, 2023 14:41
achimweigel
achimweigel approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@achimweigel achimweigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 5, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 5, 2023
@Diaphteiros Diaphteiros merged commit aa8cdb2 into gardener:master Sep 5, 2023
@Diaphteiros Diaphteiros deleted the remove-domain-restriction branch September 5, 2023 07:14
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimweigel achimweigel achimweigel approved these changes

@ccwienk ccwienk ccwienk approved these changes

@reshnm reshnm Awaiting requested review from reshnm reshnm is a code owner automatically assigned from gardener/landscaper-maintainers

@fabianburth fabianburth Awaiting requested review from fabianburth fabianburth is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) priority/3 Priority (lower number equals higher priority) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Diaphteiros @gardener-robot @achimweigel @ccwienk @gardener-robot-ci-1 @gardener-robot-ci-2