Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement kubeconfig getter templating functions with expiration timestamp #827

Merged
merged 3 commits into from
Oct 9, 2023
Merged

implement kubeconfig getter templating functions with expiration timestamp #827

merged 3 commits into from
Oct 9, 2023

Conversation

Diaphteiros
Copy link
Contributor

How to categorize this PR?

/area usability
/kind enhancement
/priority 3

Release note:

Besides the `getShootAdminKubeconfig` and `getServiceAccountKubeconfig` functions available when templating with `GoTemplate`, there are now additionally `getShootAdminKubeconfigWithExpirationTimestamp` and `getServiceAccountKubeconfigWithExpirationTimestamp` functions which work like their siblings, but return an object containing the kubeconfig as well as the token's expiration timestamp instead of returning the kubeconfig directly. All of the mentioned functions are now also available when using `Spiff` as templating engine.

@gardener-prow
Copy link

gardener-prow bot commented Sep 22, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-robot gardener-robot added area/usability Usability related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Sep 22, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 22, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 29, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 29, 2023
@Diaphteiros Diaphteiros marked this pull request as ready for review October 4, 2023 08:31
@Diaphteiros Diaphteiros requested a review from a team as a code owner October 4, 2023 08:31
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 4, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 4, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 4, 2023
@gardener-robot
Copy link

@enrico-kaack-comp You have pull request review open invite, please check

@Diaphteiros Diaphteiros merged commit 591b621 into gardener:master Oct 9, 2023
@Diaphteiros Diaphteiros deleted the templating branch October 9, 2023 12:44
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertgraeff robertgraeff robertgraeff approved these changes

@enrico-kaack-comp enrico-kaack-comp Awaiting requested review from enrico-kaack-comp enrico-kaack-comp is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else priority/3 Priority (lower number equals higher priority) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Diaphteiros @gardener-robot @robertgraeff @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3