Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement defaults for optional imports #833

Merged
merged 1 commit into from
Oct 9, 2023
Merged

implement defaults for optional imports #833

merged 1 commit into from
Oct 9, 2023

Conversation

Diaphteiros
Copy link
Contributor

How to categorize this PR?

/area usability
/kind bug
/priority 3

What this PR does / why we need it:
According to our documentation, optional data imports can be given a default value which will be used if the import is not satisfied otherwise. This PR makes it actually work.

Release note:

Default values defined in blueprints for optional data imports are now added to the imports as expected.

@gardener-prow
Copy link

gardener-prow bot commented Sep 27, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-robot gardener-robot added area/usability Usability related kind/bug Bug priority/3 Priority (lower number equals higher priority) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Sep 27, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 27, 2023
@Diaphteiros Diaphteiros marked this pull request as ready for review September 29, 2023 11:40
@Diaphteiros Diaphteiros requested a review from a team as a code owner September 29, 2023 11:40
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 29, 2023
@guewa guewa merged commit f6adb31 into gardener:master Oct 9, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 9, 2023
@Diaphteiros Diaphteiros deleted the fix-defaults branch October 9, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimweigel achimweigel achimweigel approved these changes

@reshnm reshnm Awaiting requested review from reshnm reshnm is a code owner automatically assigned from gardener/landscaper-maintainers

@fabianburth fabianburth Awaiting requested review from fabianburth fabianburth is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/usability Usability related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review priority/3 Priority (lower number equals higher priority) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Diaphteiros @achimweigel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot @guewa