Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete field for registry pull secrets in installations #834

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Obsolete field for registry pull secrets in installations #834

merged 4 commits into from
Oct 9, 2023

Conversation

robertgraeff
Copy link
Member

@robertgraeff robertgraeff commented Sep 27, 2023 •
edited by achimweigel
Loading

How to categorize this PR?

/area robustness
/kind task
/priority 3

What this PR does / why we need it:

The Installation custom resource has a field spec.registryPullSecrets. This field is obsolete. Instead the corresponding field in the Context custom resource should be used. Moreover, the field was not correctly propagated to sub-objects.

This pull request removes the field from the Installation, Execution, and DeployItem.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

- deprecated registryPullSecrets field in Installations removed

@gardener-prow
Copy link

gardener-prow bot commented Sep 27, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-robot gardener-robot added area/robustness Robustness, reliability, resilience related kind/task General task priority/3 Priority (lower number equals higher priority) needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Sep 27, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 27, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 27, 2023
@robertgraeff robertgraeff force-pushed the remove-obsolete-pullsecret-field branch from c77234c to 937d62a Compare October 9, 2023 07:36
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 9, 2023
@robertgraeff robertgraeff marked this pull request as ready for review October 9, 2023 07:46
@robertgraeff robertgraeff requested a review from a team as a code owner October 9, 2023 07:46
@robertgraeff robertgraeff merged commit 76c026a into gardener:master Oct 9, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 9, 2023
@robertgraeff robertgraeff deleted the remove-obsolete-pullsecret-field branch October 9, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimweigel achimweigel achimweigel approved these changes

@fabianburth fabianburth Awaiting requested review from fabianburth fabianburth is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/robustness Robustness, reliability, resilience related kind/task General task needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else priority/3 Priority (lower number equals higher priority) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robertgraeff @achimweigel @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot