Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality
/kind enhancement
/priority 3
What this PR does / why we need it:
Fixes two small bugs:
reflect.TypeOf(val).String()
, which caused the landscaper to crash ifval
wasnil
.GoTemplate
(because it is text-based), this caused problems forSpiff
templates without any DeployItems, because the default value was not overwritten and Spiff can't handle the empty struct when building the YAML tree. Changing the default from an empty struct to an empty map solved the problem and is also 'more correct', since all three keys hold objects (json-wise), which are represented as maps in Go. I assume that this issue went unnoticed due to Spiff being rarely used.Release note: