Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move targetresolver to controller-utils package #852

Merged
merged 2 commits into from
Oct 12, 2023
Merged

move targetresolver to controller-utils package #852

merged 2 commits into from
Oct 12, 2023

Conversation

Diaphteiros
Copy link
Contributor

@Diaphteiros Diaphteiros commented Oct 10, 2023 •
edited
Loading

How to categorize this PR?

/area dev-productivity
/kind enhancement
/priority 3

Release note:

The `targetresolver` package has been moved to the `controller-utils` module. This allows working with Targets without having to depend on the Landscaper main module.

@gardener-prow
Copy link

gardener-prow bot commented Oct 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 10, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 10, 2023
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) needs/review Needs review labels Oct 11, 2023
@Diaphteiros Diaphteiros marked this pull request as ready for review October 11, 2023 08:11
@Diaphteiros Diaphteiros requested a review from a team as a code owner October 11, 2023 08:11
@Diaphteiros Diaphteiros merged commit 43d233e into gardener:master Oct 12, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 12, 2023
@Diaphteiros Diaphteiros deleted the targetresolver branch October 12, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimweigel achimweigel achimweigel approved these changes

@fabianburth fabianburth Awaiting requested review from fabianburth fabianburth is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review priority/3 Priority (lower number equals higher priority) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Diaphteiros @achimweigel @gardener-robot-ci-2 @gardener-robot