Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to go 1.20.10 (run-int-tests) #856

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Upgrade to go 1.20.10 (run-int-tests) #856

merged 1 commit into from
Oct 13, 2023

Conversation

guewa
Copy link
Contributor

@guewa guewa commented Oct 12, 2023 •
edited
Loading

How to categorize this PR?

/area delivery
/kind regression
/priority 2

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Upgrade to go 1.20.10 fixes following CVEs:
 - CVE-2023-39323
 - CVE-2023-29409
 - CVE-2023-39318
 - CVE-2023-39319

@guewa guewa requested a review from a team as a code owner October 12, 2023 10:17
@guewa guewa requested review from reshnm and Diaphteiros October 12, 2023 10:17
@gardener-robot gardener-robot added needs/review Needs review area/delivery Delivery related priority/2 Priority (lower number equals higher priority) labels Oct 12, 2023
@gardener-robot
Copy link

@guewa Label kind/security does not exist.

@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Oct 12, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 12, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 12, 2023
@gardener-robot gardener-robot added the kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution label Oct 12, 2023
@guewa guewa added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 12, 2023
achimweigel
achimweigel requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@achimweigel achimweigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is about the files containing still the old version?
Makefile
integration-test/docker/Dockerfile

@guewa
Copy link
Contributor Author

guewa commented Oct 13, 2023 •
edited
Loading

What is about the files containing still the old version? Makefile integration-test/docker/Dockerfile

This is in landscaper-service, the new docker image referenced in the pipeline_definitions is
eu.gcr.io/gardener-project/landscaper-service/integration-test:1.20.10-alpine3.18

see landscaper-service/pull/230

@guewa guewa requested a review from achimweigel October 13, 2023 05:30
@guewa guewa merged commit 9abca2a into master Oct 13, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 13, 2023
@guewa guewa deleted the Upgrade-to-go-1.20.10 branch October 13, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimweigel achimweigel achimweigel approved these changes

@reshnm reshnm Awaiting requested review from reshnm reshnm is a code owner automatically assigned from gardener/landscaper-maintainers

@Diaphteiros Diaphteiros Awaiting requested review from Diaphteiros Diaphteiros is a code owner automatically assigned from gardener/landscaper-maintainers

@robertgraeff robertgraeff Awaiting requested review from robertgraeff

Assignees
No one assigned
Labels
area/delivery Delivery related kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review priority/2 Priority (lower number equals higher priority) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guewa @gardener-robot @achimweigel @gardener-robot-ci-1 @gardener-robot-ci-3