Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uninstall for helm deployer #859

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Fix uninstall for helm deployer #859

merged 2 commits into from
Oct 17, 2023

Conversation

achimweigel
Copy link
Contributor

How to categorize this PR?

/area deployers
/kind bug
/priority 3

What this PR does / why we need it:

Fix uninstall for helm deployer such that it is recognised when a helm release is already deleted.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

- fix uninstall for real helm deployer

@achimweigel achimweigel requested a review from a team as a code owner October 17, 2023 05:31
@achimweigel achimweigel requested review from reshnm and In-Ko October 17, 2023 05:31
@gardener-robot gardener-robot added area/deployers Deployer related kind/bug Bug priority/3 Priority (lower number equals higher priority) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 17, 2023
@achimweigel achimweigel requested review from robertgraeff and removed request for In-Ko October 17, 2023 05:31
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 17, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 17, 2023
@robertgraeff robertgraeff merged commit ed73faf into gardener:master Oct 17, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 17, 2023
@robertgraeff robertgraeff deleted the fix-helm-uninstall branch October 18, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Diaphteiros Diaphteiros Diaphteiros approved these changes

@robertgraeff robertgraeff robertgraeff approved these changes

@reshnm reshnm Awaiting requested review from reshnm reshnm is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/deployers Deployer related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review priority/3 Priority (lower number equals higher priority) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@achimweigel @Diaphteiros @robertgraeff @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot