Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log errors during di reconciliation #882

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Log errors during di reconciliation #882

merged 1 commit into from
Nov 8, 2023

Conversation

achimweigel
Copy link
Contributor

How to categorize this PR?

/area deployers
/kind enhancement
/priority 3

What this PR does / why we need it:

All errors during reconciliation of deploy items are now logged. This was not the case before.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

- All errors during reconciliation of deploy items are now logged

@achimweigel achimweigel requested a review from a team as a code owner November 8, 2023 07:04
@gardener-robot gardener-robot added area/deployers Deployer related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 8, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 8, 2023
@achimweigel achimweigel merged commit dbefbdb into gardener:master Nov 8, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 8, 2023
guewa pushed a commit that referenced this pull request Dec 5, 2023
@achimweigel @guewa
log errors during di reconciliation (run-int-tests) (#882)
6e458e1
@achimweigel achimweigel deleted the improve-logging branch February 7, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertgraeff robertgraeff robertgraeff approved these changes

@Diaphteiros Diaphteiros Awaiting requested review from Diaphteiros Diaphteiros is a code owner automatically assigned from gardener/landscaper-maintainers

Assignees
No one assigned
Labels
area/deployers Deployer related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review priority/3 Priority (lower number equals higher priority) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achimweigel @robertgraeff @gardener-robot-ci-3 @gardener-robot