-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin github.com/prometheus/client_golang to v1.12.1 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/regression
Bug that hit us already in the past and that is reappearing/requires a proper solution
needs/review
Needs review
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
labels
May 17, 2022
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
May 17, 2022
gardener-robot-ci-3
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
May 17, 2022
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
May 17, 2022
shaoyongfeng
approved these changes
May 17, 2022
himanshu-kun
approved these changes
May 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I saw that metrics
package in MCM was revendored but its not used anywhere. When vendoring mcm v0.44.2
the metrics package got removed so I guess that would solve the problem as well.
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/review
Needs review
labels
May 17, 2022
gardener-robot
added
the
status/closed
Issue is closed (either delivered or triaged)
label
May 17, 2022
shaoyongfeng
added a commit
that referenced
this pull request
May 17, 2022
…origin-rel-v0.4 [rel-v0.4] Automated cherry pick of #26: Pin github.com/prometheus/client_golang to v1.12.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/regression
Bug that hit us already in the past and that is reappearing/requires a proper solution
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
reviewed/lgtm
Has approval for merging
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind regression
Currently machine-controller-manager-provider-alicloud on startup fails with:
It seems that the issue is caused by outdated pin of the github.com/prometheus/client_golang dependency. Updating the pin to the used version fixes the issue.
Release note: