Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin github.com/prometheus/client_golang to v1.12.1 #26

Merged
merged 1 commit into from
May 17, 2022
Merged

Pin github.com/prometheus/client_golang to v1.12.1 #26

merged 1 commit into from
May 17, 2022

Conversation

ialidzhikov
Copy link
Member

/kind regression

Currently machine-controller-manager-provider-alicloud on startup fails with:

panic: duplicate metrics collector registration attempted



goroutine 1 [running]:
github.com/prometheus/client_golang/prometheus.(*Registry).MustRegister(0x1bc179a, {0xc00044ac00, 0x1, 0x1f})
/go/src/github.com/gardener/machine-controller-manager-provider-alicloud/vendor/github.com/prometheus/client_golang/prometheus/registry.go:391 +0x7f
github.com/prometheus/client_golang/prometheus.MustRegister(...)
/go/src/github.com/gardener/machine-controller-manager-provider-alicloud/vendor/github.com/prometheus/client_golang/prometheus/registry.go:176
github.com/gardener/machine-controller-manager/pkg/util/provider/metrics.init.0()
/go/src/github.com/gardener/machine-controller-manager-provider-alicloud/vendor/github.com/gardener/machine-controller-manager/pkg/util/provider/metrics/metrics.go:308 +0x7e

It seems that the issue is caused by outdated pin of the github.com/prometheus/client_golang dependency. Updating the pin to the used version fixes the issue.

Release note:

An issue causing machine-controller-manager-provider-alicloud on startup to panic with "duplicate metrics collector registration attempted" is now fixed.

@ialidzhikov ialidzhikov requested review from a team as code owners May 17, 2022 06:34
@CLAassistant
Copy link

CLAassistant commented May 17, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gardener-robot gardener-robot added kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 17, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 17, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 17, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 17, 2022
himanshu-kun
himanshu-kun approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I saw that metrics package in MCM was revendored but its not used anywhere. When vendoring mcm v0.44.2 the metrics package got removed so I guess that would solve the problem as well.

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 17, 2022
@ialidzhikov ialidzhikov mentioned this pull request May 17, 2022
Merged
@shaoyongfeng shaoyongfeng merged commit 75b9126 into gardener:master May 17, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 17, 2022
shaoyongfeng added a commit that referenced this pull request May 17, 2022
@shaoyongfeng
Merge pull request #27 from ialidzhikov/automated-cherry-pick-of-#26-…
2c9ac13 
…origin-rel-v0.4

[rel-v0.4] Automated cherry pick of #26: Pin github.com/prometheus/client_golang to v1.12.1
@ialidzhikov ialidzhikov deleted the fix/panic branch May 17, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaoyongfeng shaoyongfeng shaoyongfeng approved these changes

@himanshu-kun himanshu-kun himanshu-kun approved these changes

Assignees
No one assigned
Labels
kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ialidzhikov @CLAassistant @shaoyongfeng @himanshu-kun @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot