Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResourceExhausted error code mapping introduced for Alicloud #57

Merged
merged 5 commits into from
Sep 22, 2023
Merged

ResourceExhausted error code mapping introduced for Alicloud #57

merged 5 commits into from
Sep 22, 2023

Conversation

himanshu-kun
Copy link
Contributor

@himanshu-kun himanshu-kun commented Sep 13, 2023 •
edited by rishabh-11
Loading

What this PR does / why we need it:
Utilizes ResourceExhausted error status code. Only the errors which happen in a particular zone and are relating to insufficiency of resources are mapped to ResourceExhausted.
The intention is to enable CA to identify such errors , so that it could try another zone quicker
gardener/autoscaler#154

Which issue(s) this PR fixes:
Fixes #
Partially fixes gardener/machine-controller-manager#590

Special notes for your reviewer:
Testing done for ResourceExhausted error code.

I0913 17:21:13.756129   45533 machine_controller.go:95] Machine creation request has been processed for "shoot--i544024--ali-test-worker-1-eu-central-1b-7768f-6htmb"
E0913 17:21:13.756174   45533 machine.go:359] Error while creating machine shoot--i544024--ali-test-worker-1-eu-central-1b-7768f-6htmb: machine codes error: code = [ResourceExhausted] message = [SDK.ServerError
ErrorCode: OperationDenied.NoStock
Recommend: https://error-center.aliyun.com/status/search?Keyword=Zone.NotOnSale&source=PopGw
RequestId: AB66A046-C124-3B25-AC34-E8459C965884
Message: The resource in the specified zone is no longer available for sale. Please try other regions and zones.], "shoot--bksrv-dev--ac-bksrv-1-system-eu-central-1a-6c67f-vq6m6"]

Tickets opened related to these :
kubernetes-ac-canary/issues-ac-canary/issues/31
canary # 1742

Release note:

MCM status code `ResourceExhausted` is now utilized in mcm-provider-alicloud.

@himanshu-kun himanshu-kun requested review from a team as code owners September 13, 2023 12:59
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 13, 2023
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Sep 13, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 13, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 13, 2023
@rishabh-11 rishabh-11 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 21, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 21, 2023
rishabh-11
rishabh-11 requested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change suggested. rest looks good.
thanks for the changes

pkg/alicloud/errors/utils.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Sep 21, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 22, 2023
rishabh-11
rishabh-11 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Sep 22, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 22, 2023
@himanshu-kun himanshu-kun merged commit bf32415 into gardener:master Sep 22, 2023
7 checks passed
@himanshu-kun himanshu-kun deleted the error-code-mapping branch September 22, 2023 07:00
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 22, 2023
@dongyingbo dongyingbo mentioned this pull request Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

Assignees

@himanshu-kun himanshu-kun

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for error codes
5 participants
@himanshu-kun @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot