Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to disable automountServiceAccountToken for agents daemon sets #17

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Add flag to disable automountServiceAccountToken for agents daemon sets #17

merged 1 commit into from
Aug 19, 2022

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Aug 19, 2022 •
edited
Loading

What this PR does / why we need it:
Add flag to remove automountServiceAccountToken field for agents daemon sets.
This is needed for deployment by the Gardener extension shoot-networking-problemdetector to work correctly
with the auto mounting of projected serviceaccount tokens feature

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Add flag to disable automountServiceAccountToken for agents daemon sets optionally

@MartinWeindel MartinWeindel requested a review from a team as a code owner August 19, 2022 06:10
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Aug 19, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 19, 2022
@MartinWeindel MartinWeindel merged commit 2cc2442 into main Aug 19, 2022
@MartinWeindel MartinWeindel deleted the disable-automount-sa-token-flag branch August 19, 2022 06:49
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinWeindel @gardener-robot-ci-2 @gardener-robot