Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/trigger update on apiserver address change #45

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Fix/trigger update on apiserver address change #45

merged 2 commits into from
Jun 29, 2023

Conversation

ScheererJ
Copy link
Member

What this PR does / why we need it:
Fix/trigger update on kube-apiserver address change.

Which issue(s) this PR fixes:
None.

Special notes for your reviewer:
The second commit adds unrelated missing error handling, which was found when implementing the fix.

Release note:

Cluster configuration of network problem detector is now updated when kube-apiserver's ip address changes.

@ScheererJ ScheererJ requested a review from a team as a code owner June 29, 2023 13:21
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 29, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 29, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 29, 2023
DockToFuture
DockToFuture approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 29, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 29, 2023
MartinWeindel
MartinWeindel approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing apiserver address changes.
/lgtm

@MartinWeindel MartinWeindel merged commit 1d171a6 into gardener:main Jun 29, 2023
1 check passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 29, 2023
@dguendisch
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

@DockToFuture DockToFuture DockToFuture approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ScheererJ @dguendisch @MartinWeindel @DockToFuture @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot