Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch GCR -> Artifact-Registry #53

Merged
merged 3 commits into from
Dec 12, 2023
Merged

switch GCR -> Artifact-Registry #53

merged 3 commits into from
Dec 12, 2023

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Dec 11, 2023

GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

  • europe-docker.pkg.dev/gardener-project/snapshots for snapshots
  • europe-docker.pkg.dev/gardener-project/releases for releases
  • europe-docker.pkg.dev/gardener-project/public for combined view of snapshots + releases

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr

Release note:

Change OCI Image Registry from GCR (`eu.gcr.io/gardener-project`) to Artifact-Registry (`europe-docker.pkg.dev/gardener-project/releases`). Users should update their references.

@ccwienk
cleanup: rm obsolete/redundant attributes
15c2293
@ccwienk
trim trailing whitespace
3056602
@ccwienk
switch GCR -> Artifact-Registry
5edf955 
GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

- europe-docker.pkg.dev/gardener-project/snapshots for snapshots
- europe-docker.pkg.dev/gardener-project/releases for releases
- europe-docker.pkg.dev/gardener-project/public for read-access to
  snapshots + releases

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr
@ccwienk ccwienk requested a review from a team as a code owner December 11, 2023 22:06
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Dec 11, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 11, 2023
MartinWeindel
MartinWeindel approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thank you also for updating the nslookup check targets!

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 12, 2023
@MartinWeindel MartinWeindel merged commit 3961de2 into main Dec 12, 2023
6 checks passed
@MartinWeindel MartinWeindel deleted the gcr-to-ar branch December 12, 2023 08:03
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 12, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

@ScheererJ ScheererJ Awaiting requested review from ScheererJ

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccwienk @MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot