Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update_gcp_provider #119

Merged
merged 2 commits into from
Jul 19, 2022
Merged

update_gcp_provider #119

merged 2 commits into from
Jul 19, 2022

Conversation

bd3lage
Copy link
Contributor

@bd3lage bd3lage commented Jun 21, 2022 •
edited
Loading

How to categorize this PR?

/area quality
/kind enhancement
/priority 4

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes # landscape-issues/41

Special notes for your reviewer:

Release note:

Terraform google provider is updated to v4.19.0

@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension labels Jun 21, 2022
@gardener-robot
Copy link

@bd3lage Label priority/normal does not exist.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 21, 2022
@gardener-robot-ci-1
Copy link
Contributor

Thank you @bd3lage for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@gardener-robot gardener-robot added the priority/4 Priority (lower number equals higher priority) label Jun 21, 2022
@bd3lage bd3lage requested a review from a team as a code owner June 21, 2022 18:04
@bd3lage
Copy link
Contributor Author

bd3lage commented Jun 22, 2022

/invite @dkistner @kon-angelo

@gardener-robot
Copy link

@kon-angelo You have pull request review open invite, please check

@dkistner
Copy link
Member

dkistner commented Jul 4, 2022

/lgtm

dkistner
dkistner previously approved these changes Jul 4, 2022
View reviewed changes
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 4, 2022
@dkistner
Copy link
Member

dkistner commented Jul 4, 2022

/reviewed ok-to-test

@gardener-robot gardener-robot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 4, 2022
@AndreasBurger AndreasBurger added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 5, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 5, 2022
@bd3lage
Copy link
Contributor Author

bd3lage commented Jul 8, 2022

@kon-angelo when you get the chance this needs an additional review to be merged

kon-angelo
kon-angelo previously approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bd3lage bd3lage dismissed stale reviews from kon-angelo and dkistner via 83e7f77 July 13, 2022 15:15
@bd3lage bd3lage requested review from a team as code owners July 13, 2022 15:15
@bd3lage bd3lage requested review from a team as code owners July 13, 2022 15:15
@gardener-robot gardener-robot added needs/review Needs review and removed needs/review Needs review labels Jul 13, 2022
@kon-angelo
Copy link
Contributor

/lgtm

@kon-angelo
Copy link
Contributor

/reviewed ok-to-test

@gardener-robot gardener-robot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 13, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 13, 2022
kon-angelo
kon-angelo reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shaoyongfeng
Copy link
Contributor

/lgtm

@bd3lage
Copy link
Contributor Author

bd3lage commented Jul 18, 2022

Hi Team, what's needed for this to get merged ?

@rfranzke rfranzke merged commit e555a3c into gardener:master Jul 19, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) priority/4 Priority (lower number equals higher priority) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bd3lage @gardener-robot @gardener-robot-ci-1 @dkistner @kon-angelo @shaoyongfeng @AndreasBurger @rfranzke @gardener-robot-ci-3