Live configmap lookup to cater with stale kubelet cache #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
rfranzke
force-pushed
the
feature/refresh-configmap
branch
from
c0d3330
to
1a216b6
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
ialidzhikov
reviewed
Mar 24, 2020
rfranzke
force-pushed
the
feature/refresh-configmap
branch
from
1a216b6
to
1d63a07
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Terraformer does now lookup the relevant data stored in
ConfigMaps orSecrets live from the system instead of relying on mounted volumes. This is a breaking change as the volume mount approach does no longer work. The rationale behind it is to not rely on potentially stale kubelet cache while it mounts the volume which may, in rare cases, cause state loss.Special notes for your reviewer:
v1.0.0-devdue to breaking changes (volume mounts do no longer work) and due hopefully improved quality now with this PR and Gracefully shutdown the terraform process #36.eu.gcr.io/gardener-project/gardener/terraformer:v1.0.0-dev-rafael4image can be used for local testing/verification.terraformerpackage (Adapt to gardener/terraformer@v1.0.0 gardener-attic/gardener-extensions#629)Release note: