Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor prerequisites to use resource manager #265

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Refactor prerequisites to use resource manager #265

merged 1 commit into from
Apr 22, 2020

Conversation

schrodit
Copy link

@schrodit schrodit commented Apr 8, 2020 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #263

Special notes for your reviewer:

Still WIP:

  • adapt local dev setup
  • adapt docs

Release note:

The TestMachinery Configuration is reworked so that now configuration is done via a configuration file.
The path to the configuration can be specified via `--config` flag.
⚠️ most flags were removed and replaced by the configuration file.

The TestMachinery prerequisites deployment was refactored to now be deployed reconciled by the TestMachinery itself.
The prerequisites chart was removed and is not needed anymore.

@schrodit schrodit added the test/integration run integration test label Apr 8, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 8, 2020
@schrodit schrodit force-pushed the refactor/bootstrap branch from fca4e0b to 8402391 Compare April 9, 2020 05:45
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2020
@schrodit schrodit force-pushed the refactor/bootstrap branch from 8402391 to 0213ad1 Compare April 9, 2020 06:43
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2020
@schrodit schrodit force-pushed the refactor/bootstrap branch from 0213ad1 to 4efaba8 Compare April 9, 2020 07:58
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2020
@schrodit schrodit force-pushed the refactor/bootstrap branch from 4efaba8 to 4d24413 Compare April 9, 2020 08:39
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2020
@schrodit schrodit force-pushed the refactor/bootstrap branch from 4d24413 to fca884e Compare April 9, 2020 09:44
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 9, 2020
@schrodit schrodit force-pushed the refactor/bootstrap branch from fca884e to 45dbdcf Compare April 9, 2020 13:52
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2020
@schrodit schrodit force-pushed the refactor/bootstrap branch from 45dbdcf to ec968b1 Compare April 9, 2020 14:41
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 9, 2020
@schrodit schrodit force-pushed the refactor/bootstrap branch from ec968b1 to db53a8b Compare April 14, 2020 06:14
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 14, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 14, 2020
@schrodit schrodit force-pushed the refactor/bootstrap branch from db53a8b to 17143cb Compare April 14, 2020 07:31
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 14, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 19, 2020
@schrodit schrodit force-pushed the refactor/bootstrap branch from 719ccca to da02377 Compare April 19, 2020 15:04
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 19, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 19, 2020
@schrodit schrodit force-pushed the refactor/bootstrap branch from da02377 to 25197cc Compare April 20, 2020 06:22
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 20, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 20, 2020
@schrodit schrodit force-pushed the refactor/bootstrap branch from 25197cc to 3aa0aeb Compare April 20, 2020 09:12
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 20, 2020
@schrodit schrodit force-pushed the refactor/bootstrap branch from 3aa0aeb to 9d69378 Compare April 20, 2020 10:35
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 20, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 20, 2020
@schrodit schrodit requested a review from dguendisch April 20, 2020 11:06
@schrodit schrodit marked this pull request as ready for review April 20, 2020 11:06
@schrodit schrodit requested a review from a team as a code owner April 20, 2020 11:06
@schrodit schrodit force-pushed the refactor/bootstrap branch from 9d69378 to a13a36b Compare April 21, 2020 19:11
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 21, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 21, 2020
dguendisch
dguendisch requested changes Apr 22, 2020
View reviewed changes
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments + maybe you could check your copyright template (most new files point to 2019, a few files point to 2020 :) )

@schrodit schrodit force-pushed the refactor/bootstrap branch from a13a36b to ca9cec1 Compare April 22, 2020 12:48
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 22, 2020
@schrodit
Copy link
Author

maybe you could check your copyright template (most new files point to 2019, a few files point to 2020 :) )

My template is correct. the problem was that I copied some files.
I think I will open a separate PR that updates all Licenses.

@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 22, 2020
@schrodit schrodit requested a review from dguendisch April 22, 2020 12:53
@schrodit schrodit removed the test/integration run integration test label Apr 22, 2020
@schrodit schrodit merged commit 273c91e into gardener:master Apr 22, 2020
@schrodit schrodit deleted the refactor/bootstrap branch April 22, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy prerequisiteis at runtime
5 participants
@schrodit @dguendisch @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3