Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds field shootAnnotations to flavors #294

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Conversation

dguendisch
Copy link
Member

@dguendisch dguendisch commented Jul 2, 2020

What this PR does / why we need it:
Adds field annotations to flavors. It allows to add annotations to created shoot clusters (i.e. to trigger certain shoot behaviour).
Usage example:

flavors:
- provider: aws
  annotations:
    a: b
    c: d

Cooperates with gardener/gardener#2550

Release note:

Annotations for shoot clusters can be customized in a flavor by adding them to field `annotations`.

@dguendisch dguendisch requested a review from schrodit July 2, 2020 20:43
@dguendisch dguendisch requested a review from a team as a code owner July 2, 2020 20:43
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 2, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 2, 2020
Copy link

@schrodit schrodit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any specific reason why you called it shootAnnotations in the shoot flavor instead of annotation or additionalAnnotation as I read all 3 cases in the code.
I think we should let the testrun annotation be shoot-annotations as it may clash.
But the flavor is only for shoots so I would rather go with annotation or addtionalAnnotation. WDYT?

pkg/common/common.go Outdated Show resolved Hide resolved
pkg/testrun_renderer/templates/shoots.go Outdated Show resolved Hide resolved
pkg/testmachinery/metadata/types.go Outdated Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 3, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 3, 2020
@dguendisch
Copy link
Member Author

Addressed and renamed the shoot flavor to addtionalAnnotation in the fields and just annotation in the flavor yaml.
ptal

Copy link

@schrodit schrodit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Jul 3, 2020
@dguendisch dguendisch merged commit ea986ed into master Jul 3, 2020
@dguendisch dguendisch deleted the shootAnnotations branch July 3, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants