-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds field shootAnnotations to flavors #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any specific reason why you called it shootAnnotations
in the shoot flavor instead of annotation
or additionalAnnotation
as I read all 3 cases in the code.
I think we should let the testrun annotation be shoot-annotations
as it may clash.
But the flavor is only for shoots so I would rather go with annotation
or addtionalAnnotation
. WDYT?
132105b
to
7d4bd64
Compare
Addressed and renamed the shoot flavor to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
Adds field
annotations
to flavors. It allows to add annotations to created shoot clusters (i.e. to trigger certain shoot behaviour).Usage example:
Cooperates with gardener/gardener#2550
Release note: