Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRI Name to testmachinery metadata #360

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Conversation

dguendisch
Copy link
Member

How to categorize this PR?

/area testing
/kind enhancement

What this PR does / why we need it:
In the meantime we added a new test dimension for running tests against different container runtimes. This PR adds the CRI name to the resp. metadata so that we can later query & visualize this dimension.

Special notes for your reviewer:
I hope I didn't miss any places...
/invite @schrodit

Release note:

The CRI name of test clusters is now transported as metadata through the testmachinery

@dguendisch dguendisch requested a review from a team as a code owner July 29, 2021 08:51
@gardener-robot gardener-robot requested a review from schrodit July 29, 2021 08:51
@gardener-robot gardener-robot added area/testing Testing related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 29, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 29, 2021
Copy link

@schrodit schrodit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 29, 2021
@dguendisch dguendisch merged commit 44f6e3e into master Jul 29, 2021
@dguendisch dguendisch deleted the add-cri-dimension branch July 29, 2021 09:18
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants