Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update component cli #362

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Update component cli #362

merged 2 commits into from
Aug 13, 2021

Conversation

schrodit
Copy link

@schrodit schrodit commented Aug 13, 2021 •
edited
Loading

How to categorize this PR?

/area testing

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

we have already exposed the oci flags through the testrunner so the code change was minimal and I just had to update the lib.

Release note:

The component-cli dependency has been updated to v0.28.0

@schrodit schrodit requested a review from a team as a code owner August 13, 2021 13:27
@gardener-robot gardener-robot added area/testing Testing related needs/review Needs review labels Aug 13, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2021
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Aug 13, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 13, 2021
dguendisch
dguendisch approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Aug 13, 2021
@schrodit schrodit force-pushed the update-component-cli branch from 5dc2348 to 85c4177 Compare August 13, 2021 13:49
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2021
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Aug 13, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2021
@schrodit schrodit force-pushed the update-component-cli branch from 85c4177 to 294fabb Compare August 13, 2021 14:05
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2021
@schrodit schrodit force-pushed the update-component-cli branch from 294fabb to 41063df Compare August 13, 2021 14:23
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 13, 2021
@schrodit schrodit merged commit f5bfbdc into gardener:master Aug 13, 2021
@schrodit schrodit deleted the update-component-cli branch August 13, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch approved these changes

Assignees
No one assigned
Labels
area/testing Testing related needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@schrodit @dguendisch @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot