Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency update #382

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Dependency update #382

merged 2 commits into from
Dec 14, 2021

Conversation

hendrikKahl
Copy link
Contributor

How to categorize this PR?

/area testing
/kind technical-debt

What this PR does / why we need it:
Update several, selected dependencies to a newer version.

Primarily, this affects the library used to connect to github within prepare step as well as tm-bot. Also the helm templating Library has been updated.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Dependency updates

@hendrikKahl hendrikKahl requested a review from a team as a code owner December 13, 2021 10:35
@gardener-robot gardener-robot added area/testing Testing related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/review Needs review labels Dec 13, 2021
@hendrikKahl
Copy link
Contributor Author

/invite @dguendisch

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 13, 2021
@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Dec 13, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 13, 2021
dguendisch
dguendisch approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 13, 2021
@dguendisch
Copy link
Member

/xkcd

@testmachinery
Copy link

testmachinery bot commented Dec 14, 2021

Period Speech link
xkcd image

@gardener-robot
Copy link

@dguendisch Command /xkcd is not known.

@hendrikKahl hendrikKahl merged commit 7f7f209 into gardener:master Dec 14, 2021
@hendrikKahl hendrikKahl deleted the dep-update branch December 14, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch approved these changes

Assignees
No one assigned
Labels
area/testing Testing related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hendrikKahl @dguendisch @gardener-robot @gardener-robot-ci-1 @gardener-robot-ci-2