Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc updates #385

Merged
merged 3 commits into from
Dec 21, 2021
Merged

misc updates #385

merged 3 commits into from
Dec 21, 2021

Conversation

hendrikKahl
Copy link
Contributor

How to categorize this PR?

/area testing
/kind cleanup

What this PR does / why we need it:
Some minor updates:

  • use k8s.io/api/networking/v1 instead of extensions or betav1 for Ingress resources in go
  • updated golangci-clint & fixed issues brought up by new version
  • cleanup of vendor directory, removal of outdated github dependency

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Cleanup and switch to ingress v1

@hendrikKahl hendrikKahl requested a review from a team as a code owner December 21, 2021 13:27
@gardener-robot gardener-robot added needs/review Needs review area/testing Testing related kind/cleanup Something that is not needed anymore and can be cleaned up labels Dec 21, 2021
@hendrikKahl
Copy link
Contributor Author

/invite @dguendisch

@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Dec 21, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 21, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 21, 2021
dguendisch
dguendisch approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 21, 2021
@hendrikKahl hendrikKahl merged commit 9a07862 into gardener:master Dec 21, 2021
@hendrikKahl hendrikKahl deleted the updates branch December 21, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch approved these changes

Assignees
No one assigned
Labels
area/testing Testing related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hendrikKahl @dguendisch @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot