Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testrunner prints improved error message when exiting with failed testruns #399

Merged
merged 3 commits into from
Mar 25, 2022
Merged

testrunner prints improved error message when exiting with failed testruns #399

merged 3 commits into from
Mar 25, 2022

Conversation

hendrikKahl
Copy link
Contributor

How to categorize this PR?

/area testing
/kind enhancement

What this PR does / why we need it:
Currently, testrunner reports only in boolean format, whether one or several tests have failed. In case all criteria are met, it will exist with a generic message that does not contain any sort of context.

With this PR, Collect() will return a list of failed testruns and testrunner will print the names of failed testruns before exiting.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/invite @dguendisch

Release note:

Change signature of `result.Collect()` to return a list of failed testruns instead of true/false.

@hendrikKahl hendrikKahl requested a review from a team as a code owner March 25, 2022 12:46
@gardener-robot gardener-robot added the needs/review Needs review label Mar 25, 2022
@gardener-robot gardener-robot added area/testing Testing related kind/enhancement Enhancement, improvement, extension size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 25, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 25, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 25, 2022
dguendisch
dguendisch reviewed Mar 25, 2022
View reviewed changes
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
only one typo

pkg/testrunner/result/collect.go Outdated Show resolved Hide resolved
@hendrikKahl @dguendisch
Update pkg/testrunner/result/collect.go
1d572db 
Co-authored-by: Dieter Guendisch <dieter.guendisch@sap.com>
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 25, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 25, 2022
dguendisch
dguendisch approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 25, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 25, 2022
@hendrikKahl hendrikKahl merged commit 59c58e5 into gardener:master Mar 25, 2022
@hendrikKahl hendrikKahl deleted the testrunner-error-handling branch March 25, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch approved these changes

Assignees
No one assigned
Labels
area/testing Testing related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hendrikKahl @dguendisch @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot