Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sign-off parameter to cncf conformance pr script #413

Merged
merged 1 commit into from
Jul 6, 2022
Merged

add sign-off parameter to cncf conformance pr script #413

merged 1 commit into from
Jul 6, 2022

Conversation

hendrikKahl
Copy link
Contributor

Signed-off-by: hendrikKahl hendrik.kahl@sap.com

How to categorize this PR?

/area testing
/kind bug

What this PR does / why we need it:
CNCF conformance test PRs have a DCO check now. In order to pass, commits have to be signed-off. Hence the script will commit with -s enabled.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/invite @dguendisch

Release note:

NONE

@hendrikKahl
add sign-off parameter to cncf conformance pr script
895436a 
Signed-off-by: hendrikKahl <hendrik.kahl@sap.com>
@hendrikKahl hendrikKahl requested a review from a team as a code owner July 6, 2022 10:52
@gardener-robot gardener-robot added the needs/review Needs review label Jul 6, 2022
@gardener-robot gardener-robot added area/testing Testing related kind/bug Bug size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 6, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 6, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 6, 2022
dguendisch
dguendisch approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 6, 2022
@hendrikKahl hendrikKahl merged commit 42726c8 into gardener:master Jul 6, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 6, 2022
@hendrikKahl hendrikKahl deleted the signoff-conformance-commits branch July 6, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch approved these changes

Assignees
No one assigned
Labels
area/testing Testing related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hendrikKahl @dguendisch @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot