Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support version patterns to go back 1,2,3 or 4 minor versions #420

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Support version patterns to go back 1,2,3 or 4 minor versions #420

merged 1 commit into from
Aug 29, 2022

Conversation

dguendisch
Copy link
Member

How to categorize this PR?

/area testing
/kind enhancement

What this PR does / why we need it:
K8s version patterns in flavors now support going a few minors back relative to the latest supported K8s versions.
This allows to define test flavors that can test older K8s versions without regularly updating the flavor files.
Can be used with or without filterPatchVersions: true depending on whether you only want the latest patch version of some old minor version or all patch versions of this old minor version.

Which issue(s) this PR fixes:
Fixes #419

Special notes for your reviewer:
/invite @hendrikKahl

Release note:

Test flavor K8s version patterns in addition to `latest` now support `oneMinorBeforeLatest`, ... up to `fourMinorBeforeLatest`. Can be used with or without `filterPatchVersions: true`.

@dguendisch dguendisch requested a review from a team as a code owner August 19, 2022 13:58
@gardener-robot gardener-robot added area/testing Testing related kind/enhancement Enhancement, improvement, extension needs/review Needs review labels Aug 19, 2022
@dguendisch dguendisch changed the title support version patterns to go back 1,2,3 or 4 minor versions Support version patterns to go back 1,2,3 or 4 minor versions Aug 19, 2022
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Aug 19, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 19, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 19, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 19, 2022
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Aug 19, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 19, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 19, 2022
@gardener-robot
Copy link

@hendrikKahl You have pull request review open invite, please check

hendrikKahl
hendrikKahl approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@hendrikKahl hendrikKahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 26, 2022
@hendrikKahl hendrikKahl merged commit ec0f241 into master Aug 29, 2022
@hendrikKahl hendrikKahl deleted the minor-back-pattern branch August 29, 2022 12:54
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikKahl hendrikKahl hendrikKahl approved these changes

Assignees
No one assigned
Labels
area/testing Testing related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support more version patterns in flavor configs
5 participants
@dguendisch @gardener-robot @hendrikKahl @gardener-robot-ci-1 @gardener-robot-ci-3