Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make argo wait container resources configurable and increase defaults #425

Conversation

hendrikKahl
Copy link
Contributor

Signed-off-by: hendrikKahl hendrik.kahl@sap.com

How to categorize this PR?

/area testing
/kind bug

What this PR does / why we need it:
Occasionally, the wait container has been OOMKilled. This PR makes the resources for this container configurable via the argo & tm chart. It also increases the defaults slightly.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/invite @dguendisch

cc @acumino

Release note:

Make Argo `wait` container resources configurable and increase defaults.

Signed-off-by: hendrikKahl <hendrik.kahl@sap.com>
@hendrikKahl hendrikKahl requested a review from a team as a code owner September 23, 2022 07:21
@gardener-robot gardener-robot added area/testing Testing related kind/bug Bug needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 23, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 23, 2022
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 23, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 23, 2022
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 23, 2022
@hendrikKahl hendrikKahl merged commit 0e4aaea into gardener:master Sep 23, 2022
@hendrikKahl hendrikKahl deleted the fix/increase-argo-wait-container-limits branch September 23, 2022 09:43
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants