Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ioutil deprecation, make oauth github host configurable #429

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

hendrikKahl
Copy link
Contributor

How to categorize this PR?

/area testing
/kind technical-debt

What this PR does / why we need it:

Update all calls to deprecated io/ioutil package and replace them with corresponding functions from os / io package. See https://pkg.go.dev/io/ioutil@go1.17.13 for details.

Add a new, optional field to the github oauth configuration for the testmachinery bot. This will enable support for instances other than github.com. If not specified, it will default to github.com.

A bot config for another github instance would look like this:

apiVersion: config.testmachinery.gardener.cloud/v1beta1
kind: BotConfiguration
dashboard:
  authentication:
    cookieSecret: abc
    githubConfig:
      oAuth:
        clientId: abc
        clientSecret: abc
        redirectUrl: https://tm-bot.test/oauth/redirect
      organization: my-org
      hostname: some-github-instance.com
    provider: github

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/invite @dguendisch

Release note:

testmachinery bot supports configuration of github hostname for oauth.

@hendrikKahl hendrikKahl requested a review from a team as a code owner December 6, 2022 06:45
@gardener-robot gardener-robot added area/testing Testing related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Dec 6, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 6, 2022
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Dec 6, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 6, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 7, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 7, 2022
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Dec 8, 2022
@hendrikKahl hendrikKahl merged commit c03798f into gardener:master Dec 8, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants