Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance: add configurable contact_email_address to product.yaml #430

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Conformance: add configurable contact_email_address to product.yaml #430

merged 1 commit into from
Dec 13, 2022

Conversation

hendrikKahl
Copy link
Contributor

Signed-off-by: hendrikKahl hendrik.kahl@sap.com

How to categorize this PR?

/area testing
/kind bug

What this PR does / why we need it:
When preparing / opening PRs for conformance tests, we generate things like the product.yaml file. Recently, the structure of this file has changed and we need an additional contact_email_address now.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/invite @dguendisch

Release note:

Adapt conformance PR's product.yaml structure.

@hendrikKahl
conformance: add configurable contact_mail_address to product.yaml
4db7cb4 
Signed-off-by: hendrikKahl <hendrik.kahl@sap.com>
@hendrikKahl hendrikKahl requested a review from a team as a code owner December 12, 2022 12:13
@gardener-robot gardener-robot added area/testing Testing related kind/bug Bug needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 12, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 12, 2022
dguendisch
dguendisch approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 12, 2022
@hendrikKahl hendrikKahl merged commit 127b763 into gardener:master Dec 13, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch approved these changes

Assignees
No one assigned
Labels
area/testing Testing related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hendrikKahl @dguendisch @gardener-robot-ci-2 @gardener-robot