Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest-x pattern for major machine image versions #525

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

hendrikKahl
Copy link
Contributor

How to categorize this PR?

/area testing
/kind enhancement

What this PR does / why we need it:
Testrunner can parse latest-x pattern for major machine image and fetch the correct version from a cloudprofile. It respects expiration dates and architecture. Build versions continue to be ignored.

In case the pattern is not recognized , the version will be interpreted as string and validation is delegated to the respective garden cluster during shoot creation.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/invite @dguendisch

Release note:

Latest-x pattern can be used for machine image versions in testrun flavors

Testrunner can parse latest-x pattern for major machine image
and fetch the correct version from a cloudprofile. It respects
expiration dates and architecture. Build versions continue to be ignored.

In case the pattern is not recognized , the version will be interpreted as
string and validation is delegated to the respective garden cluster
during shoot creation.
@hendrikKahl hendrikKahl requested a review from a team as a code owner July 3, 2024 11:54
@gardener-robot gardener-robot requested a review from dguendisch July 3, 2024 11:54
@gardener-robot gardener-robot added area/testing Testing related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jul 3, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 3, 2024
@hendrikKahl hendrikKahl requested a review from dguendisch July 3, 2024 12:19
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 3, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 3, 2024
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 3, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 3, 2024
@hendrikKahl hendrikKahl merged commit c6a081c into gardener:master Jul 3, 2024
11 checks passed
@hendrikKahl hendrikKahl deleted the os-image-pattern branch July 3, 2024 12:28
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants