-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace kubetest
with hydrophone
framework
#536
Merged
hendrikKahl
merged 12 commits into
gardener:master
from
hendrikKahl:kubetest-replacement
Oct 7, 2024
Merged
Replace kubetest
with hydrophone
framework
#536
hendrikKahl
merged 12 commits into
gardener:master
from
hendrikKahl:kubetest-replacement
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dguendisch
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
🥳
2ab1b87
to
e1cf935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/testing
Testing related
kind/technical-debt
Something that is only solved on the surface, but requires more (re)work to be done properly
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/second-opinion
Needs second review by someone else
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area testing
/kind technical-debt
What this PR does / why we need it:
Refactor the way conformance tests are done in the context of Gardener, because:
kubetest
is deprecatedHydrophone fits the purpose as an easy way to invoke https://github.com/kubernetes/kubernetes/tree/master/test/conformance/image. It is no longer necessary to clone repos or download various K8s binaries.
The wrapper around hydrophone adds retry-logic as the tool itself relies on log streaming to manage its exit conditions.
Publishing test results, configurable flake attempts and other necessary configuration options are part of this PR already.
Hence,
integration/e2e
can be dropped completely.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/invite @dguendisch
Release note: