Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace kubetest with hydrophone framework #536

Merged
merged 12 commits into from
Oct 7, 2024

Conversation

hendrikKahl
Copy link
Contributor

How to categorize this PR?

/area testing
/kind technical-debt

What this PR does / why we need it:
Refactor the way conformance tests are done in the context of Gardener, because:

  • kubetest is deprecated
  • gardener/gardener's unit/integration testing environment is prow
  • a lightweight way to run k8s conformance tests is all that is needed

Hydrophone fits the purpose as an easy way to invoke https://github.com/kubernetes/kubernetes/tree/master/test/conformance/image. It is no longer necessary to clone repos or download various K8s binaries.

The wrapper around hydrophone adds retry-logic as the tool itself relies on log streaming to manage its exit conditions.
Publishing test results, configurable flake attempts and other necessary configuration options are part of this PR already.

Hence, integration/e2e can be dropped completely.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/invite @dguendisch

Release note:

Use hydrophone for conformance tests.

@hendrikKahl hendrikKahl requested a review from a team as a code owner October 1, 2024 14:52
@gardener-robot gardener-robot added area/testing Testing related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Oct 1, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 1, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 2, 2024
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
🥳

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Oct 2, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 2, 2024
@hendrikKahl hendrikKahl force-pushed the kubetest-replacement branch from 2ab1b87 to e1cf935 Compare October 2, 2024 11:35
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Oct 2, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 2, 2024
@hendrikKahl hendrikKahl merged commit 2f344f9 into gardener:master Oct 7, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants